Skip to content

Comments

bolt-launcher: 0.9.0 -> 0.14.0, fix desktop item#389683

Merged
drupol merged 1 commit intoNixOS:masterfrom
SandWoodJones:update-bolt-launcher
Mar 19, 2025
Merged

bolt-launcher: 0.9.0 -> 0.14.0, fix desktop item#389683
drupol merged 1 commit intoNixOS:masterfrom
SandWoodJones:update-bolt-launcher

Conversation

@SandWoodJones
Copy link
Contributor

Updated the bolt launcher to release 0.14.0. Also changed the desktop item's exec command as the bolt executable available on PATH does not have a version suffix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 14, 2025
@nix-owners nix-owners bot requested a review from nezia1 March 14, 2025 00:04
Copy link
Member

@nezia1 nezia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 15, 2025
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't reuse pname, replace with a literal instead.

@FliegendeWurst FliegendeWurst changed the title Update bolt launcher and fix desktop item bolt-launcher: 0.9.0 -> 0.14.0, fix desktop item Mar 16, 2025
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389683


x86_64-linux

✅ 1 package built:
  • bolt-launcher

@nezia1
Copy link
Member

nezia1 commented Mar 16, 2025

Please squash your commits to abide by contributing guidelines.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 16, 2025
@SandWoodJones SandWoodJones requested a review from drupol March 19, 2025 19:31
@drupol drupol merged commit 45951ef into NixOS:master Mar 19, 2025
27 checks passed
@SandWoodJones SandWoodJones deleted the update-bolt-launcher branch March 20, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants